I'm glad you enjoyed the story (if that's the right word to use for a sad tale).  I'm certain the last two sons of Feanor had to have had a profound influence on Elrond and Elros.  I suspect one of the reasons Elrond is seen as wise is that he's slow to judge the worth (as opposed to specific actions) of others, having known and loved someone who was simultaneously capable of both great kindness and great cruelty; he'd appreciate how easy it is for someone to fall into evil despite their best intentions.